Fix #20 - support for multiple databases #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it's a bit strange that all unit tests got passed on my Mac OS X and Linux boxes (both Python2.7/3.4). I've already tried to use the absolute path in the sub-directory, still seeing failures. Any thoughts? Thanks in advance! |
|
Well, the init command is failing for some reason. You may want to print Thanks for doing this, BTW! |
|
Found the issue, forgot to add the new template folder to the "MANIFEST.in". Will make another PR to keep the commit history clean. Thanks @miguelgrinberg for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to partially fix #20, it uses "multidb" template of Alembic. Flask-Migrate users, however, still need to change the alembic.ini and env.py to provide the required database meta information.