fix: not being able to delete a buffer when it is modified #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a file is trashed (moved to the trash) or deleted (hard deleted) in yazi, the buffer associated with the file is deleted. However, if the buffer is modified, the buffer cannot be deleted. This is because the buffer has unsaved changes. Solution: Force delete the buffer when it is being deleted, losing any unsaved changes. Originally I wanted to make sure no unsaved changes are lost, but I noticed neo-tree does not care about unsaved changes when deleting a file, so I decided to follow the same behavior. Solves #397
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a file is trashed (moved to the trash) or deleted (hard deleted) in yazi, the buffer associated with the file is deleted. However, if the buffer is modified, the buffer cannot be deleted. This is because the buffer has unsaved changes.
Solution:
Force delete the buffer when it is being deleted, losing any unsaved changes.
Originally I wanted to make sure no unsaved changes are lost, but I noticed neo-tree does not care about unsaved changes when deleting a file, so I decided to follow the same behavior.
Solves #397