Complete transition away from auto-tests

[mikeingold]

Changes

• Converts all remaining old-style tests (auto-tests.jl) to new-style tests (combinations.jl), progressing toward completion of Need unit tests with analytic solutions #67
  • Ball in 2D
  • Ball in 3D
  • Circle
  • Cylinder
  • CylinderSurface
  • Disk
  • ParaboloidSurface
  • Sphere in 2D
  • Sphere in 3D
  • Tetrahedron
  • Torus
  • Triangle
• Reduced CI runtime by about 2 minutes total, addressing Unit test completion could be faster #94

Future Work/Considerations

This PR will get combinations.jl up to around 800 lines. Should this file be partitioned into multiple files? One per geometry type? Separate file for geometries covered by specializations?

These new tests replicate the old methodology of using a unit integrand with Meshes.measure as a reference solution. More interesting integrand functions and test geometries would be nice in the longer term.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd71834) to head (2fb6d2b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          258       258           
=========================================
  Hits           258       258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikeingold]

I'm temporarily re-marking this as draft. I'm just going to go ahead and finish converting the remaining auto-tests.jl content into combinations.jl tests with this PR.

[JoshuaLampert]

This looks pretty good. In my opinion, we can keep one file for now. The file auto_tests.jl can be deleted now, can't it? Testing more interesting integrand functions would definitely be good.

[mikeingold]

This looks pretty good. In my opinion, we can keep one file for now.

Thanks! Part of me prefers the reduced code redundancy of the auto-test system, but this longer form is also much less complex to debug, and will allow for individualized rule settings and non-unit integrands for everything with time. For now, I didn’t want the lack of analytic solutions to keep holding up the transition.

The file auto_tests.jl can be deleted now, can't it?

Yes. I was planning to delete it once we’re comfortable that all CI is passing and that those tests are officially dead.

[JoshuaLampert]

Yes. I was planning to delete it once we’re comfortable that all CI is passing and that those tests are officially dead.

Tests look good.

[mikeingold]

I'm away from my PC right now so can't git rm until I get back. Otherwise I think this one is good to go.

[JoshuaLampert]

I removed the file in 2fb6d2b.