Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to integrate Frustum pending upstream changes #57

Closed
mikeingold opened this issue Aug 30, 2024 · 3 comments
Closed

Unable to integrate Frustum pending upstream changes #57

mikeingold opened this issue Aug 30, 2024 · 3 comments

Comments

@mikeingold
Copy link
Owner

Integration over Frustum and FrustumSurface is not explicitly prevented, but these types are not officially supported.

Known issues, as of 30-Aug-2024:

  • Meshes.jl has not yet defined a parametric function for Frustum
  • Tests for integrating FrustumSurface in Updated conic integration methods #51 initially yielded seemingly-incorrect values, then generated very lengthy test time increases (CI cancelled at ~30 minutes)

For now, I'm just marking these types as "not supported" pending any real demand signal for them.

@mikeingold
Copy link
Owner Author

Improvements implemented in #51 and #68 were able to fix the previous issues integrating FrustumSurface types, so those are now officially supported.

However, Meshes has not yet implemented a parametric function for Frustum, so those remain unsupported until one is implemented upstream.

@mikeingold mikeingold changed the title Problems integrating Frustum and FrustumSurface Unable to integrate Frustum pending upstream changes Sep 8, 2024
@JoshuaLampert
Copy link
Collaborator

The same applies to Ngon (apart from Triangle and Quadrangle), Polyarea, Pyramid, and Wedge.

@mikeingold
Copy link
Owner Author

Folding this back into #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants