-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion - Extend ISwipeable #1008
Comments
@MFlisar being able to identify the swipeable direction makes sense. How would the real implementation for |
I do have items that do support "starting" them and sections, that do not support this. But both items do support delete. so I would use it like following: In my case like following:
Sure, but personally I think an interface with default implementation is more discoverable (especially if the features are so closely) |
By the way, if backwards compatibility is not required, I would even replace the interface with following for the sake of simplicity:
Migration guide would simply look like following: Replace
With
|
I'd opt for the backwards compatible form. Looked over it, and your proposal makes sense. Would you like to open a PR for this? |
Done |
Thank you so much. Will be in the next update |
About this issue
I want to distinguish between items the do allow swipe left / swipe right / both. Currently I can only distinguish can swipe / can not swipe.
My suggestion is to extend the
ISwipeable
interface:What do you think about this? It's a very small and backwards compatible change with the default implementation inside the interface.
isDirectionSupported
will only be called ifisSwipeable
return true.Details
The text was updated successfully, but these errors were encountered: