Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special type format strings to docs #1987

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Add special type format strings to docs #1987

merged 1 commit into from
Oct 30, 2021

Conversation

God-damnit-all
Copy link
Contributor

@God-damnit-all God-damnit-all commented Oct 29, 2021

Adds the notes from 0038a8c to the documentation. I changed 'extended' to 'special' for clarity.

Also, in the format specifier table, I changed 'before` and 'after' to 'start' and 'end' to keep this from happening:
image

Here's a direct link to the modified document:
https://github.com/ImportTaste/gallery-dl/blob/docs/formatting.md/docs/formatting.md#special-type-format-strings

@mikf mikf merged commit 69cd573 into mikf:master Oct 30, 2021
@mikf
Copy link
Owner

mikf commented Oct 30, 2021

Thank you. Hope you don't mind if I also tinker with this for a bit myself, add more examples, etc. {_env[…]} and {_now} should also be included in this file, I think.

Also, in the format specifier table, I changed 'before` and 'after' to 'start' and 'end' to keep this from happening:

Looked like this for me:
s

@God-damnit-all
Copy link
Contributor Author

God-damnit-all commented Oct 30, 2021

Thank you. Hope you don't mind if I also tinker with this for a bit myself, add more examples, etc. {_env[…]} and {_now} should also be included in this file, I think.

Also, in the format specifier table, I changed 'before` and 'after' to 'start' and 'end' to keep this from happening:

Looked like this for me: s

Of course I don't mind, though I'm not sure if the env variables should be considered a 'special type' format string since \f isn't involved. Considering you just added 46e17c5, maybe they could be considered 'local variable fields'?

EDIT: Actually, I think system environment fields works even better. Or maybe even local system fields, though that is a bit redundant. local client fields? Though system environment fields is still my best suggestion, I feel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants