Path Change in 1.20.0, not sure if a bug or feature

[Burve]

Before 1.20.0 when I run
call "gallery-dl" -d "X:\Other Images" https://twitter.com/**someTwitterAcc**
with Twitter URL, images got actually saved to X:\Other Images\twitter\**someTwitterAcc**\, but after 1.20.0 running same command saves images to X:\Other Images\

Technically it is not a big deal, but I wanted to check if this is a bug or a feature?

Thanks

[mikf]

That's a feature. -d or --directory now specifies the exact path without any subdirectories.

You can use --dest "X:\Other Images" or -o base-directory="X:\Other Images" to have the old behavior.

[AlttiRi]

Change -d to --dest.

4edf438

---

gallery-dl/gallery_dl/option.py

Lines 94 to 98 in 4edf438

	general.add_argument(
	"--dest",
	dest="base-directory", metavar="DEST", action=ConfigAction,
	help=argparse.SUPPRESS,
	)

gallery-dl/gallery_dl/option.py

Lines 105 to 115 in 4edf438

	general.add_argument(
	"-f", "--filename",
	dest="filename", metavar="FORMAT",
	help=("Filename format string for downloaded files "
	"('/O' for \"original\" filenames)"),
	)
	general.add_argument(
	"-d", "--directory",
	dest="directory", metavar="PATH",
	help="Target location for file downloads",
	)

[Burve]

Thanks.

It solved everything.

[inthebrilliantblue]

@mikf --dest

Why did the old behavior get the new option instead of the new behavior? Changing past expected behaviors of options is typically not something one should do.

[Chevan94]

It'll be nice to have this included in the docs, I spent an hour figuring out if I was the one who derped something in my .conf file.

[AlttiRi]

In this case the change is for the unification.

There is the change log here: https://github.com/mikf/gallery-dl/releases

But yes, only "add -d/--directory and -f/--filename command-line options" note in "Additions" looks not enough for such change, I would also add a note in "Changes" about it. Maybe with a bold text, since it's a breaking change.

[mikf]

I should have communicated this better, sorry about that.

I've never really liked -d/--dest with how unspecific and unexpected its functionality is, especially if one has never used it before, and wanted to replace it with something "better". There were several questions in the past on how to specify the exact download directory, so I've added just that and "removed" the old option.

Anyway, this will be reverted to its former behavior in the next release: dcfe088

• -d/--dest/--destination to only set the base-directory like before
• -D/--directory to set the exact download location

I really didn't expect that many people to be using -d. Oh well ...

[AlttiRi]

Maybe then the new -f also should be changed to -F (or add it in the additional) to look unified with the new -D?

[inthebrilliantblue]

I should have communicated this better, sorry about that.

No worries, I was mostly pulling my hair out thinking my config file got messed up.

I've never really liked -d/--dest with how unspecific and unexpected its functionality is, especially if one has never used it before, and wanted to replace it with something "better". There were several questions in the past on how to specify the exact download directory, so I've added just that and "removed" the old option.

Anyway, this will be reverted to its former behavior in the next release: dcfe088

• -d/--dest/--destination to only set the base-directory like before
• -D/--directory to set the exact download location

I really didn't expect that many people to be using -d. Oh well ...

Lol, my real problem is since Ive been using gallery-dl for so long now that the old -d way of doing things just became my default pathing. Had the new -d been around when I started using gallery-dl I would have deleted everything and just restarted downloading. But now I have TBs of archives of sites that either are not around anymore, and would not like to redownload stuff or spend the time to reorg everything to fit the new -d. Project for another day when I have time, but not right now. I do look forward to the new -d when I get a chance to rewrite scripts, as this would solve my "windows doesnt like that character" problem in samba when linux is fine with just about anything.