Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sankaku] Download fails when url contains language #2647

Closed
Gigas002 opened this issue Jun 1, 2022 · 5 comments
Closed

[sankaku] Download fails when url contains language #2647

Gigas002 opened this issue Jun 1, 2022 · 5 comments

Comments

@Gigas002
Copy link

Gigas002 commented Jun 1, 2022

Example of bug:

$ gallery-dl "https://chan.sankakucomplex.com/ja/post/show/31177427"
gallery-dl: No suitable extractor found for 'https://chan.sankakucomplex.com/ja/post/show/31177427'
@Gigas002
Copy link
Author

Gigas002 commented Jun 1, 2022

Also, downloads from https://black.sankakucomplex.com/post/show/31177427 and https://white.sankakucomplex.com/post/show/31177427 throws the same error. The webpage is actually the same as for https://beta.sankakucomplex.com/post/show/31177427 and https://sankaku.app/post/show/31177427

@Hrxn
Copy link
Contributor

Hrxn commented Jun 1, 2022

What's the point of black.sankaku.. and white.sankakau...? Do they have any specific purpose?

Also FYI, while extending matching URLs in such a case is pretty trivial to fix, you can also "solve" this by simply changing the URL into the expected format, you know? 😄

@Gigas002
Copy link
Author

Gigas002 commented Jun 1, 2022

They exist, and they're similar to beta/app mirrors, isn't this enough reason to support them?

Regarding your second remark, let's suppose I'm a new user to gallery-dl and trying to download something from sankaku. I don't know if this website is supported which cases are covered. And while trying to download something I see the error, that No suitable extractor found for. What will be my first assumption? That sankaku isn't supported.
The point is, that user should do minimum work for program to work.

@Hrxn
Copy link
Contributor

Hrxn commented Jun 1, 2022

I did not doubt their existence, I was merely inquiring the reason behind their presence.

A subdomain like beta.<site>.<tld> indicates (usually) a beta version variant of a website, i.e. something that is actively in development, although still publicly accessible.
But white.? And black.? I was just asking out of curiosity.

Regarding your second remark, the hypothetical user could simply check this website here, and be informed that Sankaku is explicitly mentioned as a supported site.

@Gigas002
Copy link
Author

Gigas002 commented Jun 1, 2022

But white.? And black.? I was just asking out of curiosity.

Well, these were in use when sankaku have just started creating the new UI. I don't know if there are a lot of people actually using these ones right now.

Ok. The user sees the website is supported. He checks the link - it's correctly opening in browser. How would he assume, that part of url brakes the query? From my perspective, the people would rather think, that the program is broken and would either send a bug report to the author or will try to search for another software. But in any case the user will have to spend some time looking for help with his problem, while the program could have just worked.

@mikf mikf closed this as completed in 05d4a02 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants