Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Firestore Modular SDK through new Adapter and Serializer #204

Merged
merged 9 commits into from
Oct 31, 2021

Conversation

mikkopaderes
Copy link
Owner

@mikkopaderes mikkopaderes commented Oct 29, 2021

Part of #178

This change introduces the cloud-firestore-modular adapter and serializer which makes uses of the Firestore Modular SDK. Originally, it was planned to avoid creating a new module as we could've combined Compat and Modular SDK code style as shown here. But the support for it is poor and not everything is compatible.

e.g.

import { writeBatch } from 'firebase/firestore';

...

const docRef = db.collection('users').doc('user_a');
const batch = writeBatch(db);

batch.set(docRef, { name: 'Foo' }); // <-- invalid because docRef uses compat SDK

So instead, it's now ending up to be an all-in transition towards Modular SDK and the Compat SDK adapter and serializer will now be in maintenance mode and will be dropped when Firebase v10 gets released. I recommend everyone to start transitioning to the cloud-firestore-modular path moving forward.

@mikkopaderes mikkopaderes self-assigned this Oct 29, 2021
@mikkopaderes mikkopaderes merged commit 6327072 into master Oct 31, 2021
@mikkopaderes mikkopaderes deleted the firestore-modular-sdk branch October 31, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant