Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUnit equal -> strictEqual #222

Merged
merged 2 commits into from
Dec 28, 2021
Merged

QUnit equal -> strictEqual #222

merged 2 commits into from
Dec 28, 2021

Conversation

charlesfries
Copy link
Collaborator

  • Convert QUnit equal invocations to strictEqual (required in Ember 4's QUnit version)
  • Cast numbers to strings in two tests

mikkopaderes
mikkopaderes approved these changes Dec 24, 2021
View reviewed changes
Copy link
Owner

@mikkopaderes mikkopaderes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mikkopaderes mikkopaderes merged commit d3f45aa into mikkopaderes:master Dec 28, 2021
@charlesfries charlesfries mentioned this pull request Jan 19, 2022
Closed
@charlesfries charlesfries changed the title [Redo] QUnit equal -> strictEqual QUnit equal -> strictEqual Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkopaderes mikkopaderes mikkopaderes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesfries @mikkopaderes