Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions, storage emulator setup to initializer #274

Merged
merged 5 commits into from
May 15, 2023
Merged

Add functions, storage emulator setup to initializer #274

merged 5 commits into from
May 15, 2023

Conversation

charlesfries
Copy link
Collaborator

Fixes #273. Not sure how to generate the functions/storage imports

@charlesfries charlesfries changed the title Add functions, storage setup to initializer Add functions, storage emulator setup to initializer May 4, 2023
Copy link
Owner

@mikkopaderes mikkopaderes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. To create the import wrappers, you can just replicate the pattern here.

@charlesfries charlesfries marked this pull request as ready for review May 5, 2023 04:40
Copy link
Owner

@mikkopaderes mikkopaderes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for this. I'm sure the failing checks aren't caused by your change and I can investigate it at a different time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions emulator and fastboot imports
2 participants