You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears this switch statement will fail if any of the A0-3 bits are pulled down.
This is because bits 0-3 match these hardware set address bits. Default they are pulled up. But a user can configure these with hardware or dynamically pulling up or down.
The CONFIGURATION bit probably needs to be masked out with a | of 11110000 or 0xF0, then the macros redefined to be 0xN0.
Not sure what other repercussions this change would have however.
The text was updated successfully, but these errors were encountered:
There is the same problem in setResolution(). It won't actually fail but it may write when it does not need to.
Needs a systematic look through all of the code.
Arduino-Temperature-Control-Library/DallasTemperature.cpp
Line 351 in 798cfc2
It appears this switch statement will fail if any of the A0-3 bits are pulled down.
This is because bits 0-3 match these hardware set address bits. Default they are pulled up. But a user can configure these with hardware or dynamically pulling up or down.
The CONFIGURATION bit probably needs to be masked out with a | of 11110000 or 0xF0, then the macros redefined to be 0xN0.
Not sure what other repercussions this change would have however.
The text was updated successfully, but these errors were encountered: