New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include test-data/ in published isal-rs crates #27

Merged

milesgranger merged 1 commit into milesgranger:main from musicinmybrain:no-test-data-in-crate

Oct 14, 2024

Contributor

musicinmybrain commented Oct 14, 2024

This PR excludes test-data/ for published isal-rs crates for several reasons:

In practice, this test corpus is only used for the benchmarks, which are already not distributed in the crate – the tests are unaffected by omitting it.
Some of the contents are subject to complicated or unclear license terms, which is an issue for those (such as distribution packagers) who would need to redistribute the source archive (.crate file).
Omitting the test data makes the released crates vastly smaller (13K instead of 986K).


          Do not include test-data/ in published isal-rs crates

18b6ae6

milesgranger merged commit 688e09f into milesgranger:main

9 checks passed

Owner

milesgranger commented Oct 14, 2024

Thank you. 👍

musicinmybrain mentioned this pull request

Please clarify the license #28

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet