Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple shortcode presets #49

Closed
milesj opened this issue Mar 20, 2020 · 2 comments
Closed

Support multiple shortcode presets #49

milesj opened this issue Mar 20, 2020 · 2 comments

Comments

@milesj
Copy link
Owner

milesj commented Mar 20, 2020

There is no standard for shortcodes (:smile:), so every website/platform (Slack, GitHub, etc) have different implementations. Furthermore, emojibase implements its own version (since there is no standard to reference from), which results in common emojis having different shortcodes (people don't like this).

Ideally I would like to support shortcode presets from multiple sources, but I'm not entire sure where I could get this information. In an ideal world, it would look like the following:

  • Remove shortcodes from all emojibase-data.
  • Add new emojibase-data/shortcodes/*.json datasets that map hexcodes to an array of custom shortcodes for each emoji.
  • Have the consumer load and stitch them together.
@gavinr
Copy link

gavinr commented Jul 5, 2020

Follow-up or example for this:

The popular https://github.com/iamcal/js-emoji library uses https://github.com/iamcal/emoji-data. Their shortcodes can be seen here and the source is here (see short_name property). Note that these are different than the shortcodes in this repository.

I'm not saying which is right or wrong, but I'll echo that as a user it's annoying and would be great if places could start to standardize. Thanks for the hard work!

@milesj
Copy link
Owner Author

milesj commented Aug 15, 2020

Supported in the next major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants