Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g:ack_default_options only applied if g:ackprg #139

Closed
Konfekt opened this issue Jul 22, 2014 · 1 comment
Closed

g:ack_default_options only applied if g:ackprg #139

Konfekt opened this issue Jul 22, 2014 · 1 comment

Comments

@Konfekt
Copy link
Contributor

Konfekt commented Jul 22, 2014

In documentation, note that g:ack_default_options only applied if g:ackprg unset!

Thanks to

if !exists("g:ackprg")
  if executable('ack')
    let g:ackprg = "ack"
  elseif executable('ack-grep')
    let g:ackprg = "ack-grep"
  else
    finish
  endif
  let g:ackprg .= g:ack_default_options
endif

the g:ack_default_options are only applied if g:ackprg is unset.

Either

  • note this in the documentation (and explain that the options can be passed directly to g:ackprg), or
  • apply these options even if g:ack_default_options is set.
@ches
Copy link
Collaborator

ches commented Mar 1, 2015

#152 will resolve this, if that pull request doesn't get rebased soon then I'll address it myself. So I'm going to close this issue in favor of that issue/PR, but I'd like to understand use cases for having both g:ackprg and g:ack_default_options exist—if you could please comment on #152 about how you use them I'd appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants