Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A switching modeline #83

Open
toroidal-code opened this issue Apr 2, 2015 · 4 comments
Open

A switching modeline #83

toroidal-code opened this issue Apr 2, 2015 · 4 comments

Comments

@toroidal-code
Copy link

One of the things I've always really wanted to see from an Emacs powerline implementation was to actually change when you switched evil states, providing different colors and altering when you switched around.

I've started hacking together a theme that can do this, and was wondering if this would be something that the main repo would be interested in having.

output

@milkypostman
Copy link
Owner

I have no issues integrating some functionality like this. It'd be good to setup a pull request to talk about how you're implementing it.

@toroidal-code
Copy link
Author

I'll do that once I'm more comfortable with the implementation and it's a bit more complete. Right now it's a little weird, and I've made some other customizations in my fork that I'll need to filter out for a PR.

@syl20bnr
Copy link

syl20bnr commented May 3, 2015

@toroidal-code Really nice work !
I would love to see this theme merged upstream, I added it as a layer in develop branch of spacemacs and it works out of the box so I think you can submit a PR.
There is one flaw in the current implementation though, a state named iedit-insert including - is not handled properly, I quickly patched the file in spacemacs layer but I will be happy to work on a clean fix once your theme is merged upstream.

@toroidal-code
Copy link
Author

Regarding the reference to this issue, I'm a little confused about the whole 'faces that seem to be fairly independent of anything else' statement in #85

My biggest qualm with merging this as it is is that it adds a bunch of dynamically generated faces when the theme is opened for the first time each session, and quite a few that are currently unused since they've been ripped right out of the original powerline color-scheme and have no emacs equivalent. (ctrlp, gundo, etc.)

So I was just wondering what was meant when it was said that something closer to this solution would work better. Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants