Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High fan speed should have a value of 80 #95

Closed
mill1000 opened this issue Nov 3, 2023 · 2 comments · Fixed by #104
Closed

High fan speed should have a value of 80 #95

mill1000 opened this issue Nov 3, 2023 · 2 comments · Fixed by #104
Assignees

Comments

@mill1000
Copy link
Owner

mill1000 commented Nov 3, 2023

Alright thanks! So what's happening is your device uses 80 for high speed, which I removed in this commit d839872

But upon reviewing some of the reference code it looks like 80 is the correct value for "high", and 100 is for "strong".

From the Lua:

keyB["BYTE_FANSPEED_HIGH"] = 0x50

From the plugin

if (windSpeed === "Mute") {
    return 20;
} else if (windSpeed === "Low") {
    return 40;
} else if (windSpeed === "Mid") {
    return 60;
} else if (windSpeed === "High") {
    return 80;
} else if (windSpeed === "Strong") {
    return 100;
} else if (windSpeed === "Auto") {
    return 102;
} else {
    return 102;
}

Originally posted by @mill1000 in #88 (comment)

@mill1000 mill1000 self-assigned this Nov 3, 2023
@tabascoz
Copy link

tabascoz commented Nov 3, 2023

Thanks ! I tested and it works as expected with high as 80, looks my device doesn't support 100

Cheers, Fernando

@mill1000
Copy link
Owner Author

mill1000 commented Nov 7, 2023

Thanks for confirming.

This is a trivial change to make, I'm just hesitant because my devices are away for the year and I am unable to test if there are unexpected side effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants