Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal providers #50

Closed
ofhouse opened this issue Feb 7, 2021 · 1 comment · Fixed by #101
Closed

Remove internal providers #50

ofhouse opened this issue Feb 7, 2021 · 1 comment · Fixed by #101
Labels
enhancement feature/terraform Missing feature from Terraform
Milestone

Comments

@ofhouse
Copy link
Member

ofhouse commented Feb 7, 2021

Follow up from #49.

We currently define an internal provider alias for the aws provider to force the creation of some resources in us-east-1 region.
This behaviour is generally not recommended by Terraform and can cause trouble for users that work with different AWS account profiles.
e.g. you have a private (default) and work profile (alias), the internal provider would always use the default profile even when you explicitly initialize the aws provider with the alias profile.

Our initial approach here was to reduce configuration effort since the us-east-1 alias must be created and passed by the user into the module but we should follow the official recommendation from Terraform here and move it into userland.

@ofhouse ofhouse added feature/terraform Missing feature from Terraform enhancement labels Feb 7, 2021
@ofhouse ofhouse added this to the v0.8.0 milestone Feb 13, 2021
@ofhouse
Copy link
Member Author

ofhouse commented Feb 25, 2021

Terraform v0.15 introduces a new option configuration_aliases in the required_provider block for this: https://github.com/hashicorp/terraform/blob/v0.15/website/upgrade-guides/0-15.html.markdown#alternative-provider-configurations-within-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/terraform Missing feature from Terraform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant