-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GPU IndexTypes to support Milvus-GPU #259
base: master
Are you sure you want to change the base?
Conversation
Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 97.33% 97.19% -0.15%
==========================================
Files 34 34
Lines 2628 2637 +9
==========================================
+ Hits 2558 2563 +5
- Misses 70 74 +4
|
/lgtm |
/label ci-pass |
@matrixji: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@luisfmnunes could you try to fix the clang-format issue with |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: luisfmnunes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format |
/lgtm |
@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target. |
Added the GPU index types as metioned in Issue #257