Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GPU IndexTypes to support Milvus-GPU #259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

luisfmnunes
Copy link

Added the GPU index types as metioned in Issue #257

@sre-ci-robot
Copy link

Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e90aa2f) 97.33% compared to head (30ff077) 97.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   97.33%   97.19%   -0.15%     
==========================================
  Files          34       34              
  Lines        2628     2637       +9     
==========================================
+ Hits         2558     2563       +5     
- Misses         70       74       +4     
Files Coverage Δ
src/impl/types/IndexDesc.cpp 98.88% <100.00%> (+0.01%) ⬆️
src/impl/TypeUtils.cpp 97.80% <50.00%> (-0.61%) ⬇️

@matrixji
Copy link
Collaborator

matrixji commented Feb 9, 2024

/lgtm

@matrixji
Copy link
Collaborator

matrixji commented Feb 9, 2024

/label ci-pass

@sre-ci-robot
Copy link

@matrixji: The label(s) /label ci-pass cannot be applied. These labels are supported: sdk/c++, sdk/go, sdk/http, sdk/java, sdk/python, severity/critical, severity/major, severity/minor, severity/moderate, test/accuracy, test/stability, test/ut, Summer 2021, WHY NOT

In response to this:

/label ci-pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mergify mergify bot removed the ci-passed label Feb 9, 2024
@matrixji
Copy link
Collaborator

matrixji commented Feb 17, 2024

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

@sre-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Feb 20, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luisfmnunes
To complete the pull request process, please ask for approval from matrixji after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luisfmnunes
Copy link
Author

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format

@mergify mergify bot added the ci-passed label Feb 22, 2024
@matrixji matrixji added the lgtm label Feb 22, 2024
@matrixji
Copy link
Collaborator

/lgtm

@matrixji
Copy link
Collaborator

@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants