Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with iterator #286

Open
BeAllAround opened this issue Mar 26, 2024 · 14 comments
Open

Search with iterator #286

BeAllAround opened this issue Mar 26, 2024 · 14 comments
Assignees

Comments

@BeAllAround
Copy link

Describe the feature:

It doesn't seem to be possible to "search with iterator" as documented in:

https://milvus.io/docs/v2.3.x/with_iterators.md#Search-with-iterator

Describe a specific use case for the feature:

avoiding: invalid max query result window, (offset+limit) should be in range [1, 16384] ERROR

@shanghaikid
Copy link
Contributor

Do you really need this feature? if so, I will add it later.

@BeAllAround
Copy link
Author

BeAllAround commented Mar 27, 2024

@shanghaikid well, if there is a workaround where I can return more than 16384 items ( if a collection contains so ) with the milvusClient.search, do let me know. Thank you very much for your consideration.

@shanghaikid
Copy link
Contributor

@shanghaikid well, if there is a workaround where I can return more than 16384 items ( if a collection contains so ) with the milvusClient.search, do let me know. Thank you very much for your consideration.

I see, I will implement this feature.

@BeAllAround
Copy link
Author

@shanghaikid Awesome - thanks. If you could republish @zilliz/milvus2-sdk-node via npm then as well, please. That'd be great. I am using package managers to install it.

@shanghaikid
Copy link
Contributor

@shanghaikid Awesome - thanks. If you could republish @zilliz/milvus2-sdk-node via npm then as well, please. That'd be great. I am using package managers to install it.

Of course, but it takes time. stay tuned.

@shanghaikid shanghaikid self-assigned this Mar 29, 2024
@enricrp-rea
Copy link

Hi,
What is the status of the issue? It would be nice to has the iterator for search and query

@shanghaikid
Copy link
Contributor

Hi, What is the status of the issue? It would be nice to has the iterator for search and query

sorry, it's on hold,I've finished the query iterator, but based on my testing, the search iterator is not accurate, I am waiting for milvus team 's response.

@shanghaikid
Copy link
Contributor

can you give me your case, I can do some extra testing specifically for your case, like what's your schema, which metric do you like to use?

@enricrp-rea
Copy link

I need to get all primary keys from all the entities. So right now I am iterating through pagination until there are no more results left. However, the right solution would be to have the iterator

@shanghaikid
Copy link
Contributor

I need to get all primary keys from all the entities. So right now I am iterating through pagination until there are no more results left. However, the right solution would be to have the iterator

so all you need is query iterator, not search right? the query iterator is ready, but search is not good.

@enricrp-rea
Copy link

Yes, in my case i only need a query iterator. Thx

@shanghaikid
Copy link
Contributor

Yes, in my case i only need a query iterator. Thx

ok, I will release one version tomorrow.

@shanghaikid
Copy link
Contributor

Yes, in my case i only need a query iterator. Thx

Hi , v2.4.2 is released. please check here to view the usage method:

https://github.com/milvus-io/milvus-sdk-node/tree/v2.4.2?tab=readme-ov-file#whats-new-in-v242

@enricrp-rea
Copy link

enricrp-rea commented Apr 26, 2024

Hey thx for the quick reply and update. Just one last thing, I have seen that the limit is required but the documentation sais it is optional. Thx!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants