Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: filter the fields instead of create a new response obj #37845

Merged
merged 1 commit into from
Nov 22, 2024
Merged

enhance: filter the fields instead of create a new response obj #37845

merged 1 commit into from
Nov 22, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 20, 2024

/kind improvement

Here you only need to filter out the system fields, and you don’t need to recreate a response, because recreating the response will cause this part to be easily missed when adding fields later.

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Nov 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (b983ef9) to head (1102ed1).
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37845   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files        1357     1357           
  Lines      190182   190164   -18     
=======================================
- Hits       154121   154107   -14     
  Misses      30591    30591           
+ Partials     5470     5466    -4
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.21% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.52% <100.00%> (-0.21%) ⬇️

... and 34 files with indirect coverage changes

---- 🚨 Try these New Features:

@SimFG SimFG force-pushed the master-proxy-describe-collection branch from 4173071 to e969e04 Compare November 20, 2024 11:42
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
enhance: filter the fields instead of create a new response obj
1102ed1 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG force-pushed the master-proxy-describe-collection branch from e969e04 to 1102ed1 Compare November 21, 2024 02:58
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Nov 21, 2024

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 21, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 923a661 into milvus-io:master Nov 22, 2024
20 checks passed
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@SimFG @JsDove
enhance: filter the fields instead of create a new response obj (milv…
b0c4938 
…us-io#37845)

/kind improvement

Here you only need to filter out the system fields, and you don’t need
to recreate a response, because recreating the response will cause this
part to be easily missed when adding fields later.

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimFG @czs007 @sre-ci-robot