Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use V3 Onion address format exclusively in all user-facing contexts #306

Closed
yeastplume opened this issue Jan 21, 2020 · 1 comment
Closed
Labels
enhancement New feature or request
Milestone

Comments

@yeastplume
Copy link
Member

In the 3.0.0 release, there is a bit of inconsistency whereby some commands accept a wallet's address as a raw public key whereas others use the v3 Onion address format. In retrospect we should only be presenting one format to users, not both.

For the 3.1.0 release, we should try and use the v3 Onion address exclusively wherever we can, which will include

  • When specifying payment address manually on the command line, the user should be able to input an onion v3 address, not a raw key
  • When retrieving addresses for the wallet, the user should only be shown the ov3 address
  • When showing/exporting payment proof only the ov3 address should be used.

The slate format should not be changed for this, only user-facing instances where the address is displayed

The JSON-RPC APIs should be modified to accept either/or in init_send_tx via a custom formatter.

@yeastplume yeastplume added the enhancement New feature or request label Jan 21, 2020
@yeastplume yeastplume added this to the v3.1.0 milestone Jan 21, 2020
@yeastplume
Copy link
Member Author

Done via #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant