Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the PR actions of the vulncheck evaluator into a proper remediate action #1203

Closed
jhrozek opened this issue Oct 15, 2023 · 3 comments
Closed

Split the PR actions of the vulncheck evaluator into a proper remediate action #1203

jhrozek opened this issue Oct 15, 2023 · 3 comments
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Oct 15, 2023

The vulncheck evaluator does two things - checks the vulnerabilities and then performs an action based on the vulnerabilities found, like suggesting PR changes or commenting with a summary. This was all coded before we had remediations, but now that we do have a proper remediations engine we should split the actions part of the evaluator into a proper remediate module to avoid turning the vulncheck into spaghetti (esp visible once we started adding Pi support in addition to vulnerabilities)
@jhrozek jhrozek added the enhancement New feature or request label Oct 19, 2023
This was referenced Oct 19, 2023
Open
Closed
@rdimitrov rdimitrov added the priority: low Low priority label Oct 23, 2023
@jhrozek jhrozek mentioned this issue Oct 30, 2023
Merged
@jhrozek jhrozek mentioned this issue Nov 13, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 24, 2023
@jhrozek jhrozek removed the Stale label Nov 24, 2023
@jhrozek
Copy link
Contributor Author

jhrozek commented Mar 6, 2024 •
edited
Loading

When addressing this, please take comments in #2171 into account

@jhrozek jhrozek mentioned this issue Mar 6, 2024
Merged
@evankanderson evankanderson added P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage and removed priority: low Low priority labels Jul 16, 2024
@mesembria
Copy link
Contributor

Closing, will address as part of an upcoming epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jhrozek @mesembria @evankanderson @rdimitrov