Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The repository registered field is not set #2628

Closed
rdimitrov opened this issue Mar 13, 2024 · 1 comment · Fixed by #3563
Closed

The repository registered field is not set #2628

rdimitrov opened this issue Mar 13, 2024 · 1 comment · Fixed by #3563
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers

Comments

@rdimitrov
Copy link
Member

rdimitrov commented Mar 13, 2024 •
edited
Loading

The registered field in the Repository proto message is not set.

We might want to delete it or perhaps set it properly when we return responses including it.
@rdimitrov rdimitrov added bug Something isn't working good first issue Good for newcomers go Pull requests that update Go code labels Mar 13, 2024
@eleftherias
Copy link
Contributor

From what I can tell, Repository is only used to represent registered repositories. If that's the case, we should remove the registered field, because it is implied that the repository is registered.

@ChrisJBurns ChrisJBurns mentioned this issue Jun 8, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes unneeded Registered field ChrisJBurns/minder
2 participants
@eleftherias @rdimitrov