Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge configuration with defaults on provider create #3511

Closed
jhrozek opened this issue Jun 3, 2024 · 0 comments · Fixed by #3468
Closed

Merge configuration with defaults on provider create #3511

jhrozek opened this issue Jun 3, 2024 · 0 comments · Fixed by #3468
Assignees

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Jun 3, 2024

Currently we require that the whole provider configuration is passed on creating a provider which is awkward because then the user needs to pass e.g.:

{
  "github-app": {},
  "auto_registration": {
    "entities": {
      "repository": {
        "enabled": true
      }
    }
  }
}

it would be better if the default provider configuration (github-app in this case) was merged in by the provider.

@jhrozek jhrozek self-assigned this Jun 5, 2024
@jhrozek jhrozek mentioned this issue Jun 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant