Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stacklok logo in enrollment complete html page #830

Closed
lukehinds opened this issue Sep 4, 2023 · 1 comment · Fixed by #896
Closed

Use stacklok logo in enrollment complete html page #830

lukehinds opened this issue Sep 4, 2023 · 1 comment · Fixed by #896
Assignees
@eleftherias
Labels
good first issue Good for newcomers
Milestone
OSS MVP

Comments

@lukehinds
Copy link
Contributor

stacklok

We should use the stacklok logo in the html complete screen

https://github.com/stacklok/mediator/blob/main/pkg/auth/html/oauth_success.html
@lukehinds lukehinds added the good first issue Good for newcomers label Sep 4, 2023
@lukehinds lukehinds added this to the OSS MVP milestone Sep 4, 2023
@jhrozek
Copy link
Contributor

jhrozek commented Sep 5, 2023

I think this might be something @eleftherias might be interested in to get acquainted with the login and enrolment process (which would then enable her to work on the social logins perhaps?)

@eleftherias eleftherias self-assigned this Sep 7, 2023
@eleftherias eleftherias mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
OSS MVP
Development

Successfully merging a pull request may close this issue.

Add Stacklok logo to enrollment complete html page eleftherias/mediator
3 participants
@jhrozek @eleftherias @lukehinds