We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
The policy status is incorrect when we set more than 1 tag in a policy using the artifact_signature rule.
artifact_signature
To Reproduce
Steps to reproduce the behavior:
tags: [main, latest]
main
Expected behavior
In the case above it should have failed, instead it passed.
Part of the fix is to update the way we compare the tags in https://github.com/stacklok/mediator/blob/f362a4632e176613c89bc01219d8464e42f01bd4/internal/engine/ingester/artifact/artifact.go#L113 to HasAll.
HasAll
Another use case that it failed (with the up-mentioned change) is:
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Related to #831
Sorry, something went wrong.
rdimitrov
Successfully merging a pull request may close this issue.
Describe the bug
The policy status is incorrect when we set more than 1 tag in a policy using the
artifact_signature
rule.To Reproduce
Steps to reproduce the behavior:
artifact_signature
rule configured with more than 1 tag, i.e.tags: [main, latest]
main
onlyExpected behavior
In the case above it should have failed, instead it passed.
Part of the fix is to update the way we compare the tags in https://github.com/stacklok/mediator/blob/f362a4632e176613c89bc01219d8464e42f01bd4/internal/engine/ingester/artifact/artifact.go#L113 to
HasAll
.Another use case that it failed (with the up-mentioned change) is:
main
main
tag is now tailored to another image)Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: