Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

List of known issues #159

Open
axcore opened this issue Sep 2, 2022 · 3 comments
Open

List of known issues #159

axcore opened this issue Sep 2, 2022 · 3 comments

Comments

@axcore
Copy link

axcore commented Sep 2, 2022

Recently I spent some time going through the code, and compiled this list of issues. I know the author is no longer updating this mod, but perhaps this list will be useful for anyone who wants to maintain a fork.

I did not examine the code for the cauldron, enchanting table or workbench (other than confirming that they work).

Issues:

  • As noted in The chess ain't working anymore #134, chess pieces can no longer take each other, possibly due to an engine regression. This is still the case in Minetest v5.6
  • Curtains have only one colour. This looks like an oversight, since the code contains a list of colours (with only "red" in it). Note that the overlay texture clashes with any pink texture, so if you try to add pink curtains it will look like the moths have eaten it
  • On MT 5.6, sitting on the chair and cushion is broken. I tried replacing default.player_attached() and default.player_set_animation() with the equivalent calls to player_api, and the results were much better. However, the external camera still shows the player as standing up, this could be fixed
  • Various items (such as xdecor:stonepath) will be uncraftable if stairs are disabled for any reason
  • The artificial bee hive's formspec sees "Bees are making honey..." even at night, when they are not making honey (the code produces honey only during daylight hours). Changing the code to a formspec-on-demand would be a nice touch
  • The mailbox's formspec could be tweaked so that everything lines up, by replacing this line:

box[6,0.72;3.3,3.5;#555555]
...with this one:

box[6,0.72;3.3,3.9;#555555]

  • xdecor:lantern can be placed against a wall or hung from a ceiling, and when that happens, it is not in the correct orientation (for example, it is upside down when placed against a ceiling, and this looks weird)
  • xdecor:cushion_block is in the "not_in_creative_inventory" group for no obvious reason
  • The cauldron is neat, but inadequately documented. I had to read the code to work out how to use it
  • The radio/speaker are purely decorative. This should be documented so players don't drive themselves mad trying to make them produce sound
  • The correct spelling of "baricade" is "barricade". The node name should not be updated, but the description could be
@Wuzzy2
Copy link

Wuzzy2 commented Nov 25, 2022

It would be better if you posted an issue for each problem, instead of having a monster issue for everything.

@axcore
Copy link
Author

axcore commented Nov 25, 2022

That would be good advice if the mod were being updated, but as you noted in your forum post, it isn't :)

@mckaygerhard
Copy link

almost all are engine regressions.. not mod per se problems..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants