Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Per node/edge attributes #21

Closed
josqu4red opened this issue Feb 16, 2020 · 4 comments · Fixed by #48
Closed

Feature request: Per node/edge attributes #21

josqu4red opened this issue Feb 16, 2020 · 4 comments · Fixed by #48
Labels
kind/feature New feature or request

Comments

@josqu4red
Copy link

Great library!

It would be awesome to support per-resource attributes, to highlight relations between different sub-systems, for instance.

@mingrammer
Copy link
Owner

It would be good to support them. But I have no idea how to support per edge attributes. Per node attribute is very easy, EC2('name', attr=...) for instance. But the edge only can be made by shift operator now, so there is no place to inject the attribute.

Any idea?

@mingrammer mingrammer added kind/feature New feature or request question Further information is requested labels Feb 17, 2020
@warmfusion
Copy link

Could you do something where if the shifted target is a string treat it as a edge label?

EC2("MyNode") >> "EdgeNote" >> EC2("OtherNode")

For more advanced attributes, a formal object could be used?

attr = Attribute(dashed=True, color="pantone-448-c", label="Goes here")
node >> attr >> other_node

@mingrammer mingrammer removed the question Further information is requested label Feb 23, 2020
@ki11roy
Copy link
Contributor

ki11roy commented Mar 1, 2020

Please take a look at #48

@mingrammer mingrammer linked a pull request Mar 2, 2020 that will close this issue
@mingrammer
Copy link
Owner

#48 merged and Diagrams v0.7.0 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants