Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: in izomorphic app in server render memory leaks! #13

Open
royroev opened this issue Aug 26, 2016 · 3 comments
Open

Error: in izomorphic app in server render memory leaks! #13

royroev opened this issue Aug 26, 2016 · 3 comments

Comments

@royroev
Copy link

royroev commented Aug 26, 2016

profiler and headsnapshot rules!)

@ahromyak
Copy link

I am not recommending using this lib because it causes memory leaks all the time.

@CharlesCarnell
Copy link

Adding on to this, we've had to completely remove this from production after a week of sporadic downtime due to memleaks originating from this package.

Absolutely do not use this package in an isomorphic / universal application until this has been resolved.

@philn5d-ar
Copy link

philn5d-ar commented Oct 24, 2019

After some review of the code and debugging, this is caused by the event registration componentWillMount lifecycle of the NotificationContainer. This is not the correct place to register events and a few other issues in here are related to this issue. I'm lobbying for a quick resolution since this would effect those using React 15 and 16. Once React 17 is out, this will be broken altogether.

https://react-legacy.netlify.com/docs/react-component.html#componentwillmount

And for the resolution, see:

https://reactjs.org/docs/react-component.html#unsafe_componentwillmount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants