Cache feed icons

[APT37]

• I have read this document: https://miniflux.app/opinionated.html#feature-request

Since feed icons are fetched only once (when the feed is added) and never refreshed afterwards, I think it'd be a good idea to let the local device cache them instead of loading them from the server every time.

Maybe a feature to update feed icons would be useful too - maybe even support for custom icons.

[xfzv]

Relevant PR (at least for the refreshing part): #2123

[APT37]

I see. Good to know that's already being worked on. After reading the PR comments, it seems like a whole different can of worms on it's own.

Of course this doesn't have anything to do with caching, haha.

[fguillot]

Feed icons are already cached in the browser for at least 72 hours.

v2/internal/ui/feed_icon.go

Lines 28 to 36 in 562a7b7

	response.New(w, r).WithCaching(icon.Hash, 72*time.Hour, func(b *response.Builder) {
	b.WithHeader("Content-Security-Policy", `default-src 'self'`)
	b.WithHeader("Content-Type", icon.MimeType)
	b.WithBody(icon.Content)
	if icon.MimeType != "image/svg+xml" {
	b.WithoutCompression()
	}
	b.Write()
	})

You can see that in the browser console:

[APT37]

I should've checked what's actually happening. At the time I opened the issue, icons were loading rather slowly and it looked like they had to be fetched from the server each time the page was loaded.

Closing this one, since it's only about caching the icons, which is already happening.