Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with WithEndpoint() not setting Config.Endpoint #907

Closed
Shidesu opened this issue Nov 2, 2023 · 3 comments
Closed

Issue with WithEndpoint() not setting Config.Endpoint #907

Shidesu opened this issue Nov 2, 2023 · 3 comments

Comments

@Shidesu
Copy link

Shidesu commented Nov 2, 2023

Currently the 6.0.0 release has an issue with the WithEndpoint extension method not properly setting the client config Endpoint. Because of that, a minio client added through DI will always have the default endpoint.
It seems to have been fixed on the master branch.

When can we expect a release? Or at least a hotfix such as 6.0.1. The bug makes it impossible to use minio through DI.
image
Commit 3a38f1e

@SeanKilleen
Copy link

SeanKilleen commented Nov 3, 2023

Thanks for adding this! I just happened to pick up the latest client for the first time and couldn't understand what I was doing wrong.

@ebozduman
Copy link
Collaborator

ebozduman commented Nov 8, 2023

We've fixed this issue in the master branch, PR #844.
New nuget has not been created yet.
Closing...

@Shidesu
Copy link
Author

Shidesu commented Nov 8, 2023

We've fixed this issue on the master branch, PR #844. New nuget has not been created yet. Closing...

Well, part of the question was: when can we expect a Nuget?

Apart from that, thanks for the work on the package, it's nice to use 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants