Fix objects with spaces in name not returned correctly fixes #1100

[heedfull]

The Uri.UnescapeDataString method has been replaced with the HttpUtility.UrlDecode method in the BucketOperations.cs file to correctly decode the item Key. Additionally, the ListObjects_Test7 function has been added to the functional tests to test whether ListObjects lists all objects matching a prefix with a space in a non-recursive manner.

[harshavardhana]

We need to add support for encoding-type=url for List() and keep the URL escape.

[heedfull]

I'm not really sure what you mean. The new functional test I added fails without the change submitted. This is the same fix that was used for #343

There are no new failing tests because of these changes

[heedfull]

We need to add support for encoding-type=url for List() and keep the URL escape.

that's not what I was hoping to achieve with this PR. I want to add support for objects with spaces in their name. Maybe if you can give more details in separate issue then I can take a look.

[harshavardhana]

We need to add support for encoding-type=url for List() and keep the URL escape.

that's not what I was hoping to achieve with this PR. I want to add support for objects with spaces in their name. Maybe if you can give more details in separate issue then I can take a look.

Try uploading an object with + in its name this PR will break.

[heedfull]

I've added a test for a prefix with a plus character in it. It passes before and after the change.

[harshavardhana]

The reason this works is its already added

minio-dotnet/Minio/DataModel/Args/GetObjectListArgs.cs

Line 96 in 5226fa4

requestMessageBuilder.AddQueryParameter("encoding-type", "url");

[heedfull]

Anything I can do to help get this PR merged?

[ebozduman]

Sorry @heedfull
I did not notice the progress in this PR.
Running the build tests now.
As soon as the build test is complete, I'll merge it.

[heedfull]

no worries, thanks for merging.

Any plans to ship a new version of nuget package?

[ebozduman]

@heedfull

Any plans to ship a new version of nuget package?

Yes. It is in the plan.
There is a regression problem we are working on.
A new nuget package will be generated as soon as the regression issue is resolved.

[heedfull]

do you have a failing test for the regression? anything I can help with?

[ebozduman]

@heedfull

Thank you.
I filed issue #1105 for it.
The culprit is a commit in PR#1057. I have a fix and will create the PR in a bit.