-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuspec for .NetCore and .NET4.5.2 as separate packages #132
Conversation
The changes look good, going to test this on windows. @poornas |
@poornas - I am not the right person to review this PR. I will reassign to someone who is more knowledgeable in this area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the binary .nuget/nuget.exe
need to be checked into the repo? It is 4+ MB.
Some questions:
|
No we shouldn't @donatello |
It was left in because latest nuget version recommended on their website doesnt work for VS2017, and every time some one builds the package this confusion could arise until the recommended version catches up. I can remove the folder, however we need to have a way of documenting dev. dependencies. |
We should document it precisely, we shouldn't keep binaries in git repo. |
@donatello , there is nothing different about the usage of the packages. There are just meant to be used by .NET4.5.2 apps or .NetCore apps. On VS 2017, you can create console apps targeting the .NetCore framework or .Net4.5.2 framework, and import the corresponding Minio-dotnet SDK for testing. |
ping @donatello any feedback? |
Separate Nuget packages for the Minio SDK - one for .Netcore, the other for .NET4.5.2. This is required because of inconsistencies in Nuget tool causing package errors when the SDK is imported into .Netcore project.