Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuspec for .NetCore and .NET4.5.2 as separate packages #132

Merged
merged 1 commit into from
May 16, 2017

Conversation

poornas
Copy link
Contributor

@poornas poornas commented May 5, 2017

Separate Nuget packages for the Minio SDK - one for .Netcore, the other for .NET4.5.2. This is required because of inconsistencies in Nuget tool causing package errors when the SDK is imported into .Netcore project.

harshavardhana
harshavardhana previously approved these changes May 5, 2017
@harshavardhana
Copy link
Member

The changes look good, going to test this on windows. @poornas

@deekoder deekoder removed their request for review May 9, 2017 00:45
@deekoder
Copy link

deekoder commented May 9, 2017

@poornas - I am not the right person to review this PR. I will reassign to someone who is more knowledgeable in this area.

@deekoder deekoder requested review from krishnasrinivas and donatello and removed request for krishnasrinivas May 9, 2017 00:46
Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the binary .nuget/nuget.exe need to be checked into the repo? It is 4+ MB.

@donatello
Copy link
Member

donatello commented May 9, 2017

Some questions:

  1. Should there be separate documentation on how to use each of the separate packages?
  2. Also, I would appreciate steps to test out each of the different packages.

@harshavardhana
Copy link
Member

Does the binary .nuget/nuget.exe need to be checked into the repo? It is 4+ MB.

No we shouldn't @donatello

@poornas
Copy link
Contributor Author

poornas commented May 9, 2017

It was left in because latest nuget version recommended on their website doesnt work for VS2017, and every time some one builds the package this confusion could arise until the recommended version catches up. I can remove the folder, however we need to have a way of documenting dev. dependencies.

@harshavardhana
Copy link
Member

It was left in because latest nuget version recommended on their website doesnt work for VS2017, and every time some one builds the package this confusion could arise until the recommended version catches up. I can remove the folder, however we need to have a way of documenting dev. dependencies.

We should document it precisely, we shouldn't keep binaries in git repo.

@poornas
Copy link
Contributor Author

poornas commented May 9, 2017

@donatello , there is nothing different about the usage of the packages. There are just meant to be used by .NET4.5.2 apps or .NetCore apps. On VS 2017, you can create console apps targeting the .NetCore framework or .Net4.5.2 framework, and import the corresponding Minio-dotnet SDK for testing.

@harshavardhana
Copy link
Member

ping @donatello any feedback?

@harshavardhana harshavardhana merged commit 571fa41 into minio:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants