Disable SHA-256 computation for https #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
May 9, 2017
Minio/V4Authenticator.cs
Outdated
| { | ||
| // No need to compute SHA256 if endpoint scheme is https | ||
| if (client.BaseUrl.Host.StartsWith("https")) |
There was a problem hiding this comment.
We should have the client struct remember if the RestClient is secure or not. It is odd style to passing the entire IRestClient into 'SetContentSha256' and unsafe - as a thumb rule we should only passing the necessary arguments.
harshavardhana
approved these changes
May 10, 2017
donatello
approved these changes
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently minio-dotnet sdk computes sha256 for https requests. This change fixes #101.