Fix PutObject call for unknown size stream #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donatello and @krishnasrinivas , pinging for reviews. |
donatello
requested changes
Sep 26, 2017
|
|
||
| if (dataToCopy == null) | ||
| { | ||
| skipUpload = true; |
There was a problem hiding this comment.
Looks like skipUpload is not read outside the for loop, so this line can be removed.
There was a problem hiding this comment.
good catch, removed that line.
|
@krishnasrinivas , this is waiting on your review. |
donatello
approved these changes
Sep 29, 2017
krishnasrinivas
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
Currently PutObject call with unknown stream size loops infinitely. Fixed that bug and added a functional test.