Added a new method SetUserMetadata to the PostPolicy #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
reviewed
Oct 10, 2017
| string headerName = "x-amz-meta-" + key; | ||
| this.policies.Add(new Tuple<string, string, string>("eq", "$" + headerName, value)); | ||
| this.formData.Add(headerName, value); | ||
| } |
There was a problem hiding this comment.
The SetKey() method already allows the user to set form data, and the custom metadata can be passed in with the x-amz-meta prefix. Is there a reason why an additional method would help
There was a problem hiding this comment.
It is coming from here minio/minio-go#839
krisis
approved these changes
Oct 11, 2017
SetUserMetadata(key string, value string) is a better API IMO. Borrowing suggestion by @vadmeste on minio-go PR. |
wowi42
changed the title
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
here is a PR for a new feature I need for a project I am working on with @hnb2.
Feature
SetUserSpecifiedMetadata(key string, value string)allows you to add user specified metadata following this guide which mention: