Fix json logging for Mint #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove JSON formatting, as other SDKs do not use formatting - Remove console.WriteLine, so JSON logs can be parsed
poornas
requested changes
Nov 25, 2017
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
this exception for the outer try block is intended to catch Setup_Test failure as well as the inner using {} block. So it shouldn't be removed.
There was a problem hiding this comment.
In this case I have just changed the indentation here @poornas block is not removed..
poornas
approved these changes
Nov 28, 2017
nitisht
requested review from
harshavardhana
and removed request for
donatello
|
changing reviewers as @donatello is not available currently |
harshavardhana
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for minio/mint#64