Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait for test to finish #198

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Add wait for test to finish #198

merged 1 commit into from
Dec 1, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Nov 30, 2017

Fixes #193

poornas
poornas requested changes Nov 30, 2017
View reviewed changes
Minio.Functional.Tests/FunctionalTest.cs Outdated
@@ -1323,8 +1323,8 @@ private static void runQuickTests(MinioClient minioClient)
string bucketName = GetRandomName(15);
await Setup_Test(minio, bucketName);

await ListObjects_Test(minio, bucketName, null, 0);

ListObjects_Test(minio, bucketName, null, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitisht , line 1326 is missing a Wait(). You could do ListObjects_Test(minio, bucketName, null, 0).Wait(5000) instead to achieve the same as line 1326 and 1327

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sure will do @poornas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nitisht nitisht merged commit b4cf02d into minio:master Dec 1, 2017
@nitisht nitisht deleted the fix-tests branch December 1, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitisht @harshavardhana @poornas