Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update maintainers.md for package creation #231

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jun 29, 2018

and fix typo in Readme.

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not update mono_install.sh?

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW donet build -c Release is not working

dotnet build -c Release
Microsoft (R) Build Engine version 15.7.179.6572 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restoring packages for /home/harsha/repos/minio-dotnet/FileUploader/FileUploader.csproj...
  Restoring packages for /home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj...
  Restoring packages for /home/harsha/repos/minio-dotnet/Minio.Tests/Minio.Tests.csproj...
  Restoring packages for /home/harsha/repos/minio-dotnet/Minio/Minio.csproj...
  Generating MSBuild file /home/harsha/repos/minio-dotnet/Minio/obj/Minio.csproj.nuget.g.props.
  Generating MSBuild file /home/harsha/repos/minio-dotnet/FileUploader/obj/FileUploader.csproj.nuget.g.props.
  Generating MSBuild file /home/harsha/repos/minio-dotnet/Minio.Examples/obj/Minio.Examples.csproj.nuget.g.props.
  Restore completed in 374.35 ms for /home/harsha/repos/minio-dotnet/Minio/Minio.csproj.
  Restore completed in 374.35 ms for /home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj.
  Restore completed in 374.35 ms for /home/harsha/repos/minio-dotnet/FileUploader/FileUploader.csproj.
  Restoring packages for /home/harsha/repos/minio-dotnet/SimpleTest/SimpleTest.csproj...
  Generating MSBuild file /home/harsha/repos/minio-dotnet/SimpleTest/obj/SimpleTest.csproj.nuget.g.props.
  Restore completed in 25.37 ms for /home/harsha/repos/minio-dotnet/SimpleTest/SimpleTest.csproj.
  Generating MSBuild file /home/harsha/repos/minio-dotnet/Minio.Tests/obj/Minio.Tests.csproj.nuget.g.props.
  Restore completed in 506.56 ms for /home/harsha/repos/minio-dotnet/Minio.Tests/Minio.Tests.csproj.
/usr/share/dotnet/sdk/2.1.301/Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.6" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
ApiEndpoints/ObjectOperations.cs(743,53): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
V4Authenticator.cs(34,24): warning CS0169: The field 'V4Authenticator.Region' is never used [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
ApiEndpoints/BucketOperations.cs(264,32): warning AsyncFixer02: ReadToEndAsync should be used instead of new StreamReader(stream).ReadToEnd. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
ApiEndpoints/ObjectOperations.cs(152,17): warning AsyncFixer02: CopyToAsync should be used instead of stream.CopyTo. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
  Minio -> /home/harsha/repos/minio-dotnet/Minio/bin/Release/netstandard2.0/Minio.dll
NotificationTest.cs(31,30): warning CS0168: The variable 'ex' is declared but never used [/home/harsha/repos/minio-dotnet/Minio.Tests/Minio.Tests.csproj]
  SimpleTest -> /home/harsha/repos/minio-dotnet/SimpleTest/bin/Release/netcoreapp2.1/SimpleTest.dll
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(10,12): error CS0579: Duplicate 'System.Reflection.AssemblyFileVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(11,12): error CS0579: Duplicate 'System.Reflection.AssemblyInformationalVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(12,12): error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(13,12): error CS0579: Duplicate 'System.Reflection.AssemblyVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(12,12): error CS0579: Duplicate 'System.Reflection.AssemblyFileVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(13,12): error CS0579: Duplicate 'System.Reflection.AssemblyInformationalVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(15,12): error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(16,12): error CS0579: Duplicate 'System.Reflection.AssemblyVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
  FileUploader -> /home/harsha/repos/minio-dotnet/FileUploader/bin/Release/netcoreapp2.1/FileUploader.dll
  Minio.Tests -> /home/harsha/repos/minio-dotnet/Minio.Tests/bin/Release/netcoreapp2.1/Minio.Tests.dll

Build FAILED.

ApiEndpoints/ObjectOperations.cs(743,53): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
V4Authenticator.cs(34,24): warning CS0169: The field 'V4Authenticator.Region' is never used [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
ApiEndpoints/BucketOperations.cs(264,32): warning AsyncFixer02: ReadToEndAsync should be used instead of new StreamReader(stream).ReadToEnd. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
ApiEndpoints/ObjectOperations.cs(152,17): warning AsyncFixer02: CopyToAsync should be used instead of stream.CopyTo. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
NotificationTest.cs(31,30): warning CS0168: The variable 'ex' is declared but never used [/home/harsha/repos/minio-dotnet/Minio.Tests/Minio.Tests.csproj]
/usr/share/dotnet/sdk/2.1.301/Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.6" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [/home/harsha/repos/minio-dotnet/Minio/Minio.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(10,12): error CS0579: Duplicate 'System.Reflection.AssemblyFileVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(11,12): error CS0579: Duplicate 'System.Reflection.AssemblyInformationalVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(12,12): error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
Minio.Client.Examples.Core/obj/Release.Core/netcoreapp1.1/Minio.Client.Examples.Core.AssemblyInfo.cs(13,12): error CS0579: Duplicate 'System.Reflection.AssemblyVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(12,12): error CS0579: Duplicate 'System.Reflection.AssemblyFileVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(13,12): error CS0579: Duplicate 'System.Reflection.AssemblyInformationalVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(15,12): error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
obj/Release/netcoreapp2.1/Minio.Examples.AssemblyInfo.cs(16,12): error CS0579: Duplicate 'System.Reflection.AssemblyVersionAttribute' attribute [/home/harsha/repos/minio-dotnet/Minio.Examples/Minio.Examples.csproj]
    5 Warning(s)
    9 Error(s)

Time Elapsed 00:00:04.42

@kannappanr kannappanr merged commit 46a21f5 into minio:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants