Next fixes #779
Merged
Next fixes #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebozduman
requested changes
May 10, 2023
|
@ebozduman I don't know why the test fails. Locally this test passes. Can you try run it again? |
|
@ebozduman I've done a rebase to include the parallel tests. Can you run it again? |
|
I get the same result; just cannot reproduce the failure reported during build tests on the windows side. |
|
@ebozduman any news? |
lukashev-di
pushed a commit
to lukashev-di/minio-dotnet
that referenced
this pull request
May 22, 2023
* Updates for proj files * Cleanup * Change clientprovider to interface * Use ValueTask for async methods who only call sync * Use Task based stream * Cleans * Fixes * Format * Update tool * Move all to interface * New user and password env * Format * Replaces the shared filename --------- Co-authored-by: Ersan <ersan.bozduman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebozduman