Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBucketLocation API does not require path-style addressing in AWS S3 #1430

Closed

Conversation

lentitude2tk
Copy link

From the AWS S3 API documentation, we can see that the GetBucketLocation API supports virtual style access.Tested locally without any issues.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html

image

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As GetBucketLocation is deprecated, actually we suppose to use HeadBucket to fetch location instead of GetBucketLocation. I would like to leave it as is ATM.

@lentitude2tk
Copy link
Author

lentitude2tk commented Jul 16, 2024

As GetBucketLocation is deprecated, actually we suppose to use HeadBucket to fetch location instead of GetBucketLocation. I would like to leave it as is ATM.

From the perspective of code referencing hierarchy, almost all interface methods in minio-py are based on the GetBucketLocation method, first querying the region based on the bucket, and then performing secondary operations. Does the deprecated of GetBucketLocation refer to the Minio layer or the AWS side?

region = self._get_region(bucket_name)

@lentitude2tk
Copy link
Author

HeadBucket also relies on the processing of the self._get_region(bucket_name) method, which itself uses the GetBucketLocation method.

@balamurugana
Copy link
Member

It is safer side to keep using path style for GetBucketLocation for many object storage services not limiting to AWS S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants