diff --git a/cmd/gen.go b/cmd/gen.go index c1b02d97..ee738d5c 100644 --- a/cmd/gen.go +++ b/cmd/gen.go @@ -373,6 +373,7 @@ func writeType(writer io.Writer, typeProps TypeProps) error { buildSourceAnchorLink(anchor, typeProps.File, typeProps.Line), typeProps.Doc, ))) + if err != nil { return err } diff --git a/cmd/init_test.go b/cmd/init_test.go index 5931a563..839d2873 100644 --- a/cmd/init_test.go +++ b/cmd/init_test.go @@ -103,9 +103,11 @@ func TestErrorInitBadWriteFiles(t *testing.T) { mockWriteFile := func(path string, data []byte, perm os.FileMode) error { t.Log(path, filepath.Join(tc.path...)) + if path == filepath.Join(tc.path...) { return mockError } + return nil } diff --git a/cmd/merge.go b/cmd/merge.go index bfe783b6..14597ee3 100644 --- a/cmd/merge.go +++ b/cmd/merge.go @@ -105,6 +105,7 @@ func (m *Merge) mergeProject( if changeErr != nil { return changeErr } + defer changeFile.Close() writer = changeFile } diff --git a/cmd/new.go b/cmd/new.go index b2271df1..65b53232 100644 --- a/cmd/new.go +++ b/cmd/new.go @@ -142,10 +142,12 @@ func (n *New) Run(cmd *cobra.Command, args []string) error { writer = n.OutOrStdout() } else { var fragmentWriter strings.Builder + fileErr := n.TemplateCache.Execute(config.FragmentFileFormat, &fragmentWriter, change) if fileErr != nil { return fileErr } + fragmentWriter.WriteString(".yaml") outputFilename := fragmentWriter.String() @@ -154,6 +156,7 @@ func (n *New) Run(cmd *cobra.Command, args []string) error { outputFilename = replacer.Replace(outputFilename) outputPath := filepath.Join(config.ChangesDir, config.UnreleasedDir, outputFilename) + fileErr = n.MkdirAll(filepath.Dir(outputPath), core.CreateDirMode) if fileErr != nil { return fileErr diff --git a/then/stdin.go b/then/stdin.go index 54756c67..e389dd77 100644 --- a/then/stdin.go +++ b/then/stdin.go @@ -30,6 +30,7 @@ func WithReadWritePipe(t *testing.T) (*os.File, *os.File) { if err := reader.Close(); err != nil { t.Fatal("failure to close reader:", err) } + if err := writer.Close(); err != nil { t.Fatal("failure to close writer:", err) }