Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1452: Remove feature flag & redundant code #305

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Jul 5, 2024

What does this pull request do?

  • remove old templates
  • update .ene.example
  • get rid of conditionals
  • update CSS
  • removed behave tests as part of the CircleCi config.yml (will need to tidy up cla-end-to-end-tests at a later time).

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

- update css
- remove old templates
- update templates
- removing redundant config
- update tests
- remove environment variables
- remove `behave` step in cicleci
   - current tests provide same/better coverage
@MazOneTwoOne MazOneTwoOne force-pushed the EL-1452-remove-feature-flag-and-redundant-code branch from 9a9a74c to 9e8d254 Compare July 8, 2024 11:11
@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review July 8, 2024 11:12
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner July 8, 2024 11:12
.env.example Show resolved Hide resolved
fala/templates/footer.html Outdated Show resolved Hide resolved
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jul 15, 2024

@MazOneTwoOne MazOneTwoOne merged commit a50985d into main Jul 15, 2024
9 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1452-remove-feature-flag-and-redundant-code branch July 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants