Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1776 add security and robots endpoints #371

Merged
merged 6 commits into from
Nov 15, 2024
Merged

EL-1776 add security and robots endpoints #371

merged 6 commits into from
Nov 15, 2024

Conversation

willc-work
Copy link
Contributor

@willc-work willc-work commented Nov 8, 2024

What does this pull request do?

Adds 2 endpoints for NCSC to check but it is also good practice to have these
add security.txt from moj standard template
https://github.com/ministryofjustice/security-guidance/blob/3245a63a5e3816a17d253eadcf81b4f2ee97663f/docs/security.txt#L4
add robots to allow crawlers in prod only

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@willc-work willc-work force-pushed the EL-1776-ncsc branch 4 times, most recently from 62a817d to 81e17bd Compare November 8, 2024 14:42
@willc-work willc-work marked this pull request as ready for review November 8, 2024 15:40
@willc-work willc-work requested a review from a team as a code owner November 8, 2024 15:40
fala/apps/adviser/views.py Outdated Show resolved Hide resolved
fala/urls.py Outdated Show resolved Hide resolved
@willc-work willc-work force-pushed the EL-1776-ncsc branch 2 times, most recently from 8e26a2c to 3971587 Compare November 13, 2024 11:29
add security.txt file and content

update robots to allow crawlers in prodcution and not for uat/staging
Copy link

sonarcloud bot commented Nov 14, 2024

Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willc-work willc-work merged commit 679bfdb into main Nov 15, 2024
8 checks passed
@willc-work willc-work deleted the EL-1776-ncsc branch November 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants