-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EL-1776 add security and robots endpoints #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willc-work
force-pushed
the
EL-1776-ncsc
branch
4 times, most recently
from
November 8, 2024 14:42
62a817d
to
81e17bd
Compare
willc-work
force-pushed
the
EL-1776-ncsc
branch
from
November 8, 2024 15:45
ec79679
to
cca51c8
Compare
willc-work
commented
Nov 8, 2024
willc-work
commented
Nov 8, 2024
willc-work
force-pushed
the
EL-1776-ncsc
branch
from
November 8, 2024 17:14
cca51c8
to
9324568
Compare
psweeting1
reviewed
Nov 12, 2024
psweeting1
reviewed
Nov 12, 2024
willc-work
force-pushed
the
EL-1776-ncsc
branch
2 times, most recently
from
November 13, 2024 11:29
8e26a2c
to
3971587
Compare
add security.txt file and content update robots to allow crawlers in prodcution and not for uat/staging
willc-work
force-pushed
the
EL-1776-ncsc
branch
from
November 13, 2024 12:13
3971587
to
27dc951
Compare
Quality Gate passedIssues Measures |
psweeting1
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds 2 endpoints for NCSC to check but it is also good practice to have these
add security.txt from moj standard template
https://github.com/ministryofjustice/security-guidance/blob/3245a63a5e3816a17d253eadcf81b4f2ee97663f/docs/security.txt#L4
add robots to allow crawlers in prod only
Any other changes that would benefit highlighting?
Intentionally left blank.
Checklist