Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1532: Footer not expanding correctly #377

Merged
merged 4 commits into from
Nov 15, 2024
Merged

EL-1532: Footer not expanding correctly #377

merged 4 commits into from
Nov 15, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

What does this pull request do?

  • override style of template, so that body does not have min-height. This means that the footer can expand.

Any other changes that would benefit highlighting?

  • n/a

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner November 13, 2024 12:26
psweeting1
psweeting1 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's raise a ticket to find where the JS injected styles are coming from?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

psweeting1
psweeting1 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne changed the title EL-1523: Footer not expanding correctly EL-1532: Footer not expanding correctly Nov 15, 2024
@MazOneTwoOne MazOneTwoOne merged commit 769d095 into main Nov 15, 2024
8 checks passed
@MazOneTwoOne MazOneTwoOne deleted the el-1532-footer-not-expanding-correctly branch November 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psweeting1 psweeting1 psweeting1 approved these changes

Assignees
No one assigned
Labels
Approved UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @psweeting1