Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1902: 404 page post rebase #387

Merged
merged 2 commits into from
Dec 12, 2024
Merged

EL-1902: 404 page post rebase #387

merged 2 commits into from
Dec 12, 2024

Conversation

HettieS
Copy link
Contributor

@HettieS HettieS commented Dec 11, 2024

What does this pull request do?

See other PR for details. This is post rebase.
#384

Any other changes that would benefit highlighting?

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@HettieS HettieS requested a review from a team as a code owner December 11, 2024 11:48
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Contributor

@willc-work willc-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this but would value @psweeting1 giving it a once over too

Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HettieS HettieS merged commit 46284be into main Dec 12, 2024
10 checks passed
@HettieS HettieS deleted the EL-1902-404-page-post-rebase branch December 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants