Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and person routing #1872

Open
teneightfive opened this issue Aug 3, 2021 · 0 comments
Open

Move and person routing #1872

teneightfive opened this issue Aug 3, 2021 · 0 comments

Comments

@teneightfive
Copy link
Contributor

Issue/question

As part of the new design for move and person pages the routing has been constructed so that the root of those apps redirects to match the first "tab". Each tab is currently a separate route, mostly due to wanting to reduce unnecessary calls which would need to be made if all of this content was displayed on one page and using JavaScript to show/hide tabs.

The question has been raised whether this is the best approach and whether it would make more sense to serve the first tab as the base route.

Currently:

/person/:id/ # redirect to /person/:id/personal-details
/person/:id/personal-details # renders first tab
/person/:id/moves # renders another tab

/move/:id/ # redirect to /person/:id/warnings
/move/:id/warnings # renders first tab
/move/:id/timeline # renders another tab
...

Possibly alternative:

/person/:id/ # renders first tab
/person/:id/moves # renders another tab

/move/:id/ # renders first tab
/move/:id/timeline # renders another tab
...

This would also tie into a suggestion from @ElizabethGoddard that we should remove the tab name from the breadcrumb (see screenshot):

Screenshot 2021-07-21 at 09 37 43

Another added benefit is we don't need to worry about changing the redirect route if the tab names/links change. (Of course, this could also be made to be more dynamic too but this would be extra work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant