Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous court hearing start times passed #630

Open
solidgoldpig opened this issue Jun 29, 2020 · 0 comments
Open

Ambiguous court hearing start times passed #630

solidgoldpig opened this issue Jun 29, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@solidgoldpig
Copy link
Contributor

We allow the user to enter freeform text for start time of a court hearing

Error__Is_this_move_associated_with_a_court_case__-_Create_a_move

There is no indication of what's a valid time in the hint, but we do provide examples when a validation error occurs.

The example shown 12:00 has led some users to enter strings such as 2:00. While the input is valid, it results in the start time being recorded as 2am. This is probably not what the user intends.

We should should probably:

  • stop accepting 24hr XX:XX as an allowable input format
  • show something like this as an example for example: 10am or 2.30pm

Alternatively we could spot and query the user when an ambiguous[0] time is entered

[0] Currently we have the following behaviour

2pm -> 2pm
2:00 -> 2am
2 -> ?? -> Invalid
14:00 -> 2pm
14 -> 2pm

NB. a simple number is fine is greater than or equal to 10, but ambiguous if less than 10.

@solidgoldpig solidgoldpig added the bug Something isn't working label Jun 29, 2020
@jason-sims jason-sims added enhancement New feature or request and removed bug Something isn't working labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants