Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for git hash on deployments #810

Open
teneightfive opened this issue Sep 22, 2020 · 0 comments
Open

Check for git hash on deployments #810

teneightfive opened this issue Sep 22, 2020 · 0 comments

Comments

@teneightfive
Copy link
Contributor

Problem

Our current deployment job within Circle waits for the command to trigger the kubernetes deployment to finish before marking it as complete and triggering the rest of the workflow.

This has caused false positives to occur when a deployment was not successfully completed and the pods did not start with the correct code deployed.

Possible solution

To ensure a correct positive we could poll the healthcheck endpoint with the git sha that is expected to be deployed to wait for the pods to have successfully started before completing the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant